Skip to content

Set empty default values for reverse location#1

Open
evenly-epic-mule wants to merge 1 commit into
masterfrom
empty_defaults
Open

Set empty default values for reverse location#1
evenly-epic-mule wants to merge 1 commit into
masterfrom
empty_defaults

Conversation

@evenly-epic-mule

Copy link
Copy Markdown
Owner

Description

Set empty default values for reverse location to make sure that the markers aren't printed in the messages pushed by PokeAlarm

How Has This Been Tested?

location lookup failes about once a day, before it generated errors like on the screen below, now the fields are simply empty.

Screenshots (if appropriate):

before
pkmn
after
pkmn

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Wiki Update

not needed

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

otherwise the markers are printed in the message destroying the link / message (on slack at least)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant