Change get_bucket to load only required bucket#242
Open
ibarria0 wants to merge 2 commits intoeudicots:masterfrom
Open
Change get_bucket to load only required bucket#242ibarria0 wants to merge 2 commits intoeudicots:masterfrom
ibarria0 wants to merge 2 commits intoeudicots:masterfrom
Conversation
Contributor
Author
|
I forgot to mention. This is an issue when upload to an s3 bucket and you only have access to the particular bucket, not every bucket of the account. This is the case for when creating IAM users for clients that only have permissions for the client's particular bucket. |
Contributor
Author
|
Bumpy mc bumperton with bumpersauce...... |
Contributor
Author
|
Ok, so... A bunch of tests fails because of the way the interaction with AWS is being tested. I'm gonna have to sit on this for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now get_bucket() calls _get_buckets(). This tries to get all the buckets for the API KEY. The problem with this is that for example in my case I provide clients with IAM keys that can only access their particular bucket, not all the buckets in my company's account. The method fails because it tries to list all buckets and it does not have permission.
There is no reason for get_bucket to try to get all the buckets in the account.
I've made changes so that it fetches only the bucket supplied by conf.json.