Fix outer derivative by replacing cwiseproduct with explicit matvec. #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing such a nice piece of software!
There seems to be a mistake in how the derivative of the normal/tangent is computed with respect to the x or y directions. The derivative of the normalized vector (n_norm) wrt the non-normalized one (n) is a 3 x 3 matrix that should be fully multiplied with the vector (dn_x/dx, dn_y/dx, dn_z/dx) while currently only a single column is multiplied elementwise. This is only an issue for terrains with non-zero second-order derivatives. Changing these lines resulted in fewer incorrect gradient values according to IPOpt's gradient checker for me.