Bump minimum Go version to 1.26 - #287
Merged
Merged
Conversation
The trailing contractNonce++ after the last contract of each deployment sequence is never read. staticcheck v0.8 reports it as SA4006.
Dependencies have started to require Go 1.26 (goose v3.28.0 in #284), and the CI toolchain is pinned with GOTOOLCHAIN=local, so those updates fail before the first go command. Move the go directive, every workflow go-version, the Docker build image and the docs to 1.26, and bump the pinned staticcheck to v0.8.1, the release built against the 1.26 toolchain.
SummaryClean, well-scoped Go 1.26 bump: go.mod directive, all four CI jobs, the dependabot-fix job and the Docker build base are consistently moved to 1.26, docs updated, and the staticcheck pin is bumped to v0.8.1 (whose go directive is confirmed 1.26.0 vs v0.7.0's 1.25). The two removed Issues
Reviewed @ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the project to Go 1.26. Dependencies have started to require it (goose v3.28.0 in #284), and since the CI toolchain runs with
GOTOOLCHAIN=localthose dependabot updates currently fail before the firstgocommand:Changes
go.modgo directive 1.25.7 → 1.26.0go-version: 1.26.xin_shared-check.yaml,_shared-build.yaml(all four build jobs) anddependabot-fix.ymlDockerfilebuild stage ongolang:1.26contractNonce++statements removed inscenarios/xentoken/deployment.go; staticcheck v0.8 reports them as SA4006 and would fail the check jobVerification (with the go1.26.0 toolchain)
go mod tidymakes no further change,go vet,gofmt -s,scripts/check-core-imports.sh, thewith_blob_v1,ckzgbuild and the full test suite passmake generate-symbolsproduces no diff, so the yaegi symbol files are unaffectedplugin/symbolsreports nothingOnce merged, #284 can be rebased and should pass.