feat(spamoor): support auto-starting built-in default spammers#1445
Open
pk910 wants to merge 1 commit into
Open
feat(spamoor): support auto-starting built-in default spammers#1445pk910 wants to merge 1 commit into
pk910 wants to merge 1 commit into
Conversation
barnabasbusa
reviewed
Jul 6, 2026
| "max_mem": 800, | ||
| "extra_args": [], | ||
| # start spamoor's built-in "Regular Chain Load" default group on first launch | ||
| "start_chainload": False, |
Collaborator
There was a problem hiding this comment.
I'd argue to enable this by default.
If you assume someone to add spamoor in their list, I'd expect spamming to happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spamoor: support auto-starting built-in default spammers
Summary
Spamoor is getting a reworked default-spammer system (ethpandaops/spamoor#254): built-in defaults are inserted on first launch and can be auto-started by a stable technical key via the new
--startup-defaultsflag. This PR exposes that feature throughspamoor_params, so a devnet can start the built-in "Regular Chain Load" and "Fuzzing" groups (or any other default) without defining its own startup spammers.Changes
New
spamoor_paramsoptions (all default to off/empty, so existing configs are unaffected):start_chainload/start_fuzzingmap to the built-in default group keysregular-chain-load/fuzzing.defaultsaccepts any built-in default key (e.g.eoatx-heavy,blob-average,gas-burner); entries are deduplicated againststart_chainload/start_fuzzing, so overlapping values don't conflict.--startup-defaults=key1,key2,...appended.README.md/network_params.yaml.Dependency
--startup-defaultsflag does not exist in current spamoor releases (latest: v1.2.2). This PR must wait for the next spamoor release containing that change; until then the flag would makespamoor:latestfail to start when any of the new options are enabled (defaults-off configs are unaffected).Testing
kurtosis lintpasses.spamoor_paramsfield patterns (input parser defaults → struct → sanity check → service cmd).