Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backwards-compatibility for ENS mainnet requirement, let NameNotFound raise #3581

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhinay
Copy link

@abhinay abhinay commented Jan 16, 2025

What was wrong?

  • The code still contained a backward compatibility try/except block related to ENS name resolution, which was scheduled to be removed in Web3.py v7.
  • This block prevented NameNotFound from being raised directly, instead converting it into InvalidAddress under certain conditions.

Related to Issue #
3580

Closes #
3580

How was it fixed?

  • Removed the try/except NameNotFound block so that NameNotFound raises naturally.
  • Updated the relevant test to ensure the new behavior.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@abhinay abhinay force-pushed the remove-backcompat-ens-handling branch from 6358acc to 85bfd0a Compare January 16, 2025 17:54
@reedsa
Copy link
Contributor

reedsa commented Jan 17, 2025

Update: Answered my own question, this was discussed in the issue itself #3580

@fselmo @kclowes I think the code comment about updating for v7 was forgotten here. If the exception handling is removed and technically breaking, will this have to wait for the version 8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants