deprecated estimateGas and buildTransaction in v5 contract #2438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes (ethereum#2340) * Add 'Breaking Change' and 'Deprecation' to our valid newsfragment types * Add newsfragment for new newsfragment categories * Remove removal section of release notes
* Drop python 3.6 * Remove parity tests * Add newsfragment for py36 drop
* fix: correct type for effectiveGasPrice (Wei, not int) * fix: correct type for gas and gas_limit (int, not Wei) * lint: removed unused type imports of Wei * Add newsfragment for Wei/int typing fixes Co-authored-by: kclowes <[email protected]>
* Require websockets v10+ - Remove event loop parameter * Add newsfragment for websockets upgrade
* ➕ Add Python 3.10 support to CI * Dropped support for all parities * Change docker image to use 3.10 * Update pytest-asyncio plugin * Mark async fixture as such, clean up pytest DeprecationWarnings Signed-off-by: Harmouch101 <[email protected]> Co-authored-by: Felipe Selmo <[email protected]> Co-authored-by: kclowes <[email protected]>
* 🧹 clean unnecessary utf-8 encoding declaration * 📝 add newsfragment.rst Signed-off-by: Harmouch101 <[email protected]>
ethereum#2254) * Added caching to the async session in request.py and AsyncHTTPProvider
* Add all types of towncrier documents to pyproject.toml * Fix formatting for old newsfragments * Don't show Misc content for consistency
* Update dependencies * Add newsfragment for dep upgrades
* 📝 replace all instances of Web3 with w3 Signed-off-by: Harmouch101 <[email protected]> * Remove unnecessary w3 arguments to tests while reviewing PR ethereum#2357 Co-authored-by: Felipe Selmo <[email protected]>
* An example how to manage local private key using env How to manage private keys using environment variable, how to generate them, and some security warnings. * Fix extra period Inserted by the editor? * add content tweaks and newsfragment Co-authored-by: Marc Garreau <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
Signed-off-by: Harmouch101 <[email protected]>
* Refactor logic for attaching a `Method` class as a property rather than a method. Instead of implicitly setting `mungers=None`, explicitly set the `is_property` flag on `Method` to `True`. This also facilitates attaching new methods and properties to modules. * Fix up some tests in test_method.py that were falsely passing to actually test correctly. Add tests for new `is_property` flag for the `Method` class. * Create `test_module.py` and add tests for `attach_methods()`
|
just realized doc changes are still needed here I will make those in the next couple days |
|
Actually, there isn't a doc portion of this. Since there will not be docs published for the v5 branch. At least, I wouldn't think there would be. I deprecated the methods but did not update the docs. I will rename all the methods in the docs on the asyncify-contract branch. |
* Resolve Typo in documentation. * Add newsfragment for doc fix Co-authored-by: kclowes <[email protected]>
* Cache eth.chain_id in simple_cache_middleware (ethereum#2425) * Add caching for sync chain_id * Remove async chainId setter Will add async chainId to the cache once the simple_cache_middleware is available on async * Add docs * Add newsfragment for simple_cache_middleware, take out old, confusing newsfragment
|
Thanks @dbfreem! The docs on this branch (v5) should maintain the deprecation warnings. The doc deprecation warnings can be removed in The changes in |
|
I am not sure how I got the docs out of sync here. My intention was to not remove those etc docs in v5. I was going to update the contract docs in v5. I will take care of this in a couple days. |
* docs: fix example * Add newsfragment for typo Co-authored-by: kclowes <[email protected]>
* fix: add chainId to txn params * fix: error message on chain id hex to int * Add newsfragment Co-authored-by: kclowes <[email protected]>
- Upgrade the go version used in the geth steps for circleci
- Added test_eth_get_transaction_receipt_unmined and test_eth_wait_for_transaction_receipt_unmined to the list of flaky tests with timeout issues.
- Adds support for extended resolvers for wildcard resolution as defined by ENSIP-10. - Adds the method ``parent()`` to the ENS class whose function is to extract the proper parent from an ENS name. - Adds the ``ens_encode_name()`` method that uses DNS name-encoding standards with a few tweaks, such as skipping the fully-encoded length validation for the domain (limit of 255 for DNS) and encoding the empty names as defined by ENSIP-10 as a single zero byte ``b'\x00'``. Unrelated: - Minor cleanup for some existing ens tests
- Test wildcard resolver functionality using a basic resolver with support for the `resolve()` method and validate the parent ens domain and its subdomains within the resolve method of the contract. - Test the new ``ens_encode_name()`` from the ``ens.utils`` module. - Test the new ``ENS.parent()`` method to extract a parent from an ENS name.
- Make ``ENS.resolve()`` an internal method to provide a better user experience / less confusion. ``ENS.address()`` and ``ENS.name()`` should better abstract forward and backward resolution without the need to expose the ``resolve()`` method as part of the API. - Normalize the name being passed into ``ENS.resolver()`` since this is an exposed method for user input. This is done on other methods for the class but was not yet done for ``ENS.resolver()``.
…ure/contractDeprecateMethods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Deprecating buildTransaction and estimateGas in the v5 branch. I will remove them in the asyncify-contract branch so they are effectively removed in v6
Related to Issue #1416
Todo: