Skip to content

removed deprecated methods from eth and geth #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 11, 2022
Merged

removed deprecated methods from eth and geth #2432

merged 9 commits into from
May 11, 2022

Conversation

dbfreem
Copy link
Contributor

@dbfreem dbfreem commented Apr 20, 2022 •
edited
Loading

What was wrong?

Removed deprecated methods from eth and geth

Related to Issue #1416

Todo:

@dbfreem dbfreem marked this pull request as draft April 20, 2022 10:04
@dbfreem dbfreem marked this pull request as ready for review April 21, 2022 02:10
@dbfreem dbfreem marked this pull request as draft April 21, 2022 02:31
@dbfreem dbfreem marked this pull request as ready for review April 21, 2022 09:32
@dbfreem
Copy link
Contributor Author

dbfreem commented Apr 23, 2022

Going to set this back to draft becuase I thought protocolVersion wasn't used anymore but it is. So I need to add it back.

@dbfreem dbfreem marked this pull request as draft April 23, 2022 19:39
@dbfreem
Copy link
Contributor Author

dbfreem commented Apr 25, 2022

@kclowes based on this comment it looks like eth_versionModule was removed from geth so was my initial thoughts correct around removing the protocole_version and protocolVersion methods from eth?

@dbfreem dbfreem marked this pull request as ready for review April 25, 2022 00:29
@kclowes
Copy link
Collaborator

kclowes commented Apr 27, 2022

@kclowes based on this comment it looks like eth_versionModule was removed from geth so was my initial thoughts correct around removing the protocole_version and protocolVersion methods from eth?

Yeah, protocolVersion can be removed. We'll need to be sure that we have a deprecation warning in v5 though. Let me know if you want me to add an issue to track the v5 deprecation. Thanks!

@dbfreem
Copy link
Contributor Author

dbfreem commented Apr 27, 2022

I am busy for the next week so it may be good to merge this and create an issue for v5 deprecation and tag me on it.

@dbfreem
Copy link
Contributor Author

dbfreem commented May 5, 2022

protocol_version is already deprecated so this PR should be good to go.

kclowes
kclowes approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and it looks like we do have a deprecation warning in v5, so this should be good to go. Thanks!

@kclowes kclowes merged commit 7e758f5 into ethereum:master May 11, 2022
@dbfreem dbfreem mentioned this pull request May 18, 2022
Merged
pacrob pushed a commit that referenced this pull request May 23, 2022
@dbfreem
removed deprecated methods from eth and geth (#2432)
7b952d4
@dbfreem dbfreem deleted the feature/remove-camelCase branch July 9, 2022 10:18
@DefiDebauchery DefiDebauchery mentioned this pull request Jul 18, 2022
Closed
@pacrob pacrob mentioned this pull request Jan 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbfreem @kclowes