Skip to content

Use /opt/boost as installation target for osx CI #16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

clonker
Copy link
Member

@clonker clonker commented Apr 14, 2025

This fixes the warnings we have seen earlier in #15982 so that the PEDANTIC=OFF switch can be removed again.

Copy link
Contributor

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using a different installation prefix is a good solution.

By the way, what is the reason Boost has to be compiled from source and the version from homebrew is not sufficient?

@clonker clonker enabled auto-merge April 14, 2025 08:47
@clonker clonker disabled auto-merge April 14, 2025 09:05
@clonker
Copy link
Member Author

clonker commented Apr 14, 2025

I think this was initially done because we also draw our binary releases from this and there have been slight and subtle breaking changes (e.g. the filesystem handling) in the past when changing Boost versions. For our binaries it doesn't matter so much because it's all statically linked together and there is no visible boost dependency anymore. It does matter for homebrew (or arch linux when using the aur package), as they build against the latest and therefore you'd see these little differences there. OTOH, they are not official releases of ours and should be thoroughly tested before used in production.

@clonker clonker merged commit e1bf062 into develop Apr 14, 2025
75 checks passed
@clonker clonker deleted the soften_macos_pedantic_switch branch April 14, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants