-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Adds NatSpec to AST for struct definitions. #14119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
Changelog.md
Outdated
@@ -29,6 +29,7 @@ Language Features: | |||
|
|||
|
|||
Compiler Features: | |||
* NatSpec: Add support for NatSpec documentation in ``struct`` definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the changelog for the already released 0.8.19 version; you're gonna have to move this up to line 10 (after the enum entry).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than some minor indent/changelog issues.
BTW, please remember to switch draft PRs to reviewable when they're ready for review.
Added NatSpec to AST for struct definitions
Fixes #12295