feat(tests): Typed txs are invalid and void before their fork #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Nov 5, 2025
pdobacz
force-pushed
the
tests/tx-types
branch
3 times, most recently
from
ed3503d to
bd14c29
Compare
marioevz
approved these changes
Nov 26, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM, I'll push some changes and we can merge.
| """ | ||
| Transaction's initcode for a contract-creating transaction is too large. | ||
| """ | ||
| TYPE_1_TX_PRE_FORK = auto() |
Member
There was a problem hiding this comment.
I didn't catch on to this being duplicate in two files. This might be an artifact of the weld, I'll open an issue.
| """ | ||
| Tests that an EIP-2930 tx has no effect before Berlin. | ||
| """ | ||
| eip2930_tx_validity_test() |
Member
There was a problem hiding this comment.
This can be accomplished via parametrize_by_fork. I'll push a change in a bit.
marioevz
force-pushed
the
tests/tx-types
branch
from
bd14c29 to
9bc682d
Compare
chfast
reviewed
Nov 26, 2025
packages/testing/src/execution_testing/client_clis/clis/ethrex.py
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1754 +/- ##
===============================================
- Coverage 86.08% 86.08% -0.01%
===============================================
Files 743 743
Lines 44072 44076 +4
Branches 3891 3891
===============================================
+ Hits 37938 37941 +3
- Misses 5656 5657 +1
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Opening as draft, as I am not sure this makes sense (also CI fails for a mysterious reason and I should port from this test.EDIT: done, marked ready for reviewThe goal is to have specifically a state test, where not only tx type being not supported is tested, but additionally that no unexpected changes got through to the state, this comes up as uncovered in
evmone.So my question is: do we want a test like this? If yes I'll fix the issues and also add the same thing for other missed types.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.@ported_frommarker.