Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

πŸ—’οΈ Description

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@LouisTsai-Csie LouisTsai-Csie changed the base branch from forks/osaka to forks/amsterdam November 4, 2025 13:55
@LouisTsai-Csie LouisTsai-Csie self-assigned this Nov 4, 2025
@LouisTsai-Csie LouisTsai-Csie force-pushed the eips/amsterdam/eip-7904 branch from a90f77b to 0d812e3 Compare November 4, 2025 14:32
@marioevz
Copy link
Member

marioevz commented Nov 4, 2025

We should do uv run fill --fork Amsterdam on this change just to get a number of the tests that break with this change to try to answer these questions:

  • How many tests per fork folder fail (tests/frontier, tests/byzantium, etc).
  • Try to fill the static tests in tests/static and see how many of them fail.

@fselmo
Copy link
Contributor

fselmo commented Nov 4, 2025

Sorry @LouisTsai-Csie. I re-created forks/amsterdam from the latest forks/osaka. It is now up to date. I can help you rebase hereΒ if you'd like but I think you are still waiting on #1737 right?

@LouisTsai-Csie LouisTsai-Csie force-pushed the eips/amsterdam/eip-7904 branch from 0d812e3 to f077570 Compare November 5, 2025 14:16
@LouisTsai-Csie
Copy link
Collaborator Author

Hi @fselmo i've successfully rebased, but i am still waiting for #1737

@fselmo fselmo force-pushed the forks/amsterdam branch 2 times, most recently from cb3daac to dfeccbd Compare November 17, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants