feat: add support for EIP-7782 (6 sec slots) #1411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
changed the title
morph-dev
force-pushed
the
eips/osaka/eip-7782
branch
from
bf2e2a7 to
ce05f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We don't have a spec implementation for EIP-7782 (also known as 6-second slots).
How was it fixed?
Added initial spec implementation, to get things started.
I implemented these changes in geth (github.com/morph-dev/go-ethereum/tree/eip7782).
Note: I would also like to highlight one thing. In
check_gas_limitfunction, we need to have custom logic for the fork block and I wasn't sure how exactly to do it. I usedFORK_CRITERIA, but this doesn't really work if fork is not yet scheduled.Cute Animal Picture
Disclaimer: It's my first time contributing to execution specs