Invalid block if system contract is empty on call or call fails #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider re-directing this PR at the |
|
Might need to take another look at this since it might modify behavior of prior system contracts, but according to this message https://discord.com/channels/595666850260713488/1351309992837251195/1361391543595962669, that should not be the case. |
marioevz
force-pushed
the
invalid-block-on-missing-system-contracts
branch
from
bea2827 to
739829b
Compare
marioevz
force-pushed
the
invalid-block-on-missing-system-contracts
branch
from
739829b to
28fd22f
Compare
marioevz
force-pushed
the
invalid-block-on-missing-system-contracts
branch
from
28fd22f to
c159057
Compare
|
Ready to review, it's now independent of #1182 since I've removed the commits from that branch, although it will have a conflict because it touches the same code as that PR. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIPs 7002 and 7251 have been updated to define the expected outcome in case of execution failure or code absence:
ethereum/EIPs#9508
ethereum/EIPs#9582
How was it fixed?
Conditions for zero-length code and execution failure have been added to the system contract calls.
I'm not sure if this change affects EIP-2935, although I think we should not cherry-pick which system-contracts invalidate a block and which don't.
Cute Animal Picture