Implement EIP-7873 and EIP-5920 #1180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
force-pushed
the
eips/osaka/eip-7873
branch
from
4411f3c to
99e3a93
Compare
Carsons-Eels
reviewed
Apr 8, 2025
| ) | ||
| push(evm.stack, U256(1)) | ||
| except AssertionError: | ||
| # TODO: This behavior has not been |
There was a problem hiding this comment.
@SamWilsn had mentioned that we want to avoid TODOs directly in our code. I think the comment is good and explanitory, but should we spin the TODO bit off into an issue and track it that way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #1173 )
(closes #1181 )
What was wrong?
The EOF implementation lacks the EIP-7673 (TX Create) and EIP-5920 (PAY Opcode)
Related to Issue #1173
Related to Issue #1181
How was it fixed?
Implement the relevant EIPs.