-
Notifications
You must be signed in to change notification settings - Fork 282
Transition types #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamWilsn
wants to merge
39
commits into
ethereum:master
Choose a base branch
from
SamWilsn:transition-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Transition types #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
commented
Nov 20, 2024
@@ -24,6 +27,7 @@ class NoTestsFound(Exception): | |||
|
|||
|
|||
def run_blockchain_st_test(test_case: Dict, load: Load) -> None: | |||
load.fork.fork_criteria = ByBlockNumber(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line feels like a hack, but I'm not sure what the correct solution would look like. Open to suggestions!
0c777ae
to
d5b2b6b
Compare
update storage trie type (ethereum#1070 ethereum#1071)
* port ethereum#1098 to prague * port ethereum#1011 to prague
….0-tests run [email protected] tests
prague-devnet-6 changes
* enable testing for all forks * catch invalid signatures * refactor validate_transaction * define accessed_addresses at the start * update variable name to BLOB_BASE_FEE_UPDATE_FRACTION * refund_counter definition * create encode_receipt function * create process_system_transaction * update gas calc * explicitly define code_address in call* * fix decode_receipt
d5b2b6b
to
7ba21d8
Compare
Closed
fix: check y_parity value (ethereum#1107)
* refactor blob gas logic There are parallels between how the regular block gas is handled and how the blob gas is handled. This commit refactors blob gas canculation to bring them in line with block gas * create BlockEnvironment and TransactionEnvironment Create the BlockEnvironment and TransactionEnvironment dataclasses BlockEnvironment holds data that is chain or block scoped TransactionEnvironment holds data that is transaction scoped Message holds data that is specific to a message call * refactor validate_header * update t8n * update evm tracing * backport changes to cancun * port to shanghai * port changes to paris * port to london * port berlin * port istanbul * port constantinople * port byzantium * port spurious_dragon * port older forks * fix t8n receipts * update testing * process_withdrawals update * fixes for doc * remove execution_spec_tests entry The tests from execution_spec_tests should now be a part of EEST * use default_factory in BlockOutput * minor fixes 1 * define current_block_number in block_hash opcode * rename tx_index to index_in_block * fix vm test runs
7ba21d8
to
808a1e9
Compare
808a1e9
to
e845300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Header/block types near fork transitions weren't strict enough.
How was it fixed?
Made them stricter.
Cute Animal Picture