Skip to content

Conversation

raxhvl
Copy link
Member

@raxhvl raxhvl commented Sep 22, 2025

🗒️ Description

Additional base test cases targeting account access, balance transfer, storage access, and block rewards.

CHORE: Additionally, this test moves the fork to be applied to the entire file instead of each test.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@raxhvl raxhvl self-assigned this Sep 22, 2025
@raxhvl raxhvl added scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes labels Sep 22, 2025
@raxhvl
Copy link
Member Author

raxhvl commented Sep 22, 2025

Depends on ethereum/execution-specs#1434 and ethereum/execution-specs#1433

@raxhvl raxhvl marked this pull request as ready for review September 22, 2025 09:56
@fselmo
Copy link
Collaborator

fselmo commented Sep 22, 2025

@raxhvl I updated the commit hash here to point to the latest commit in the EELS branch with all the fixes for these. All tests are passing now.

@fselmo fselmo force-pushed the fix/eip-7928/account-access branch from ba8f6ff to 04b9614 Compare September 29, 2025 19:50
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@fselmo fselmo merged commit 28e339e into main Sep 29, 2025
16 checks passed
@fselmo fselmo deleted the fix/eip-7928/account-access branch September 29, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants