fix(tests): Block-Level Access List invalid tests #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added
type:bug
fselmo
force-pushed
the
fix/block-access-list-tests
branch
from
ebce7e1 to
e4ead05
Compare
marioevz
approved these changes
Sep 9, 2025
5 tasks
raxhvl
pushed a commit
that referenced
this pull request
Sep 15, 2025
* refactor: Make modifier internal / private API * fix(tests): Fix BlockAccessListExpectation to forbid extras; fix tests * Add note to changelog for BAL tests fixes * Update to latest commit in BAL specs branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fixes issues not caught by #2102. We fixed the t8n model to not allow extras but we did not fix the expectation model. We still had invalid tests that we did not catch which were silently still filling. This should resolve any issues with extra fields and should correctly set up the test expectations.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.