-
Notifications
You must be signed in to change notification settings - Fork 174
📄 docs(tests): Update EIP-7928 test case document to include no-op and OOG #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Delegated accounts (EIP-7702) are not covered, when CALL/DELEGATECALL/STATICCALL/CALLCODE is called for delegated account there are edge case where first account get loaded but we dont have gas for second load etc. There are two variants:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR!
I've added some comments to the document as I feel we should modify our approach here slightly. Thanks!
2104098
to
e7367f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome test ideas!
I feel the distinction I mention in my comment is extremely important and we should at least mention it so we don't miss on implementing all of the different flavors of these scenarios.
ea7a1b6
to
bcaf230
Compare
Some other small OOG ideas
|
🗒️ Description
New OOG test cases proposed by @rakita have been added to the
test_cases.md
for EIP-7928. The no-op test case, which was missed during the rebase of the framework changes, has been patched in.Related Reth PR: paradigmxyz/reth#17765 and bluealloy/revm#2903
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.