new(tests): add benchmarks with mass binop opcodes #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
commented
May 13, 2025
chfast
commented
May 13, 2025
danceratopz
reviewed
May 13, 2025
danceratopz
reviewed
May 13, 2025
chfast
force-pushed
the
benchmarks/mass_binop_simple
branch
2 times, most recently
from
c640925 to
e442d03
Compare
chfast
added
scope:tests
danceratopz
approved these changes
May 14, 2025
There was a problem hiding this comment.
LGTM! Verified the traces with help from @chfast, cf ethereum/evmone#1222
Just one small suggestion made in the comment blow (ipsilon#8). Feel free to add or discard.
Approved, please merge when you're ready!
|
I plan to enable this for |
3 tasks
chfast
force-pushed
the
benchmarks/mass_binop_simple
branch
from
b2df5ca to
5b845e3
Compare
This adds the benchmarks for EVM execution focused on binary instructions (takes two values, produces one). The benchmark has simple structure: the contract code is the infinite loop will up to the code size limit with the parametrized binop applied to two initial values balanced with DUP2 instruction.
chfast
force-pushed
the
benchmarks/mass_binop_simple
branch
from
5b845e3 to
153e172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This adds the benchmarks for EVM execution focused on binary instructions (takes two values, produces one).
The benchmark has simple structure: the contract code is the infinite loop will up to the code size limit with the parametrized binop applied to two initial values balanced with DUP2 instruction.
🔗 Related Issues
#1571
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.