Get rid of extra requests data copying when calculating requests hash #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
requests-optimization
branch
from
739eaa2 to
8db34c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1092 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 159 159
Lines 17221 17225 +4
=======================================
+ Hits 16242 16246 +4
Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
requested changes
Dec 27, 2024
test/state/requests.hpp
Outdated
| /// Raw encoded data of requests object: first byte is type, the rest is request objects. | ||
| evmc::bytes raw_data; | ||
|
|
||
| explicit Requests(Type _type, const evmc::bytes& data = {}) |
There was a problem hiding this comment.
Usage of bytes type seems inefficient. In the system_call() we are forced to create a temporary object of bytes just to be quicly replaced with "type + data". It may be better to use bytes_view here.
There was a problem hiding this comment.
true, I forgot that we can get rid of bytes on the system_call() side
Change Requests representation to byte array of type + requests data.
gumb0
force-pushed
the
requests-optimization
branch
from
8db34c8 to
2ce18d2
Compare
chfast
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Requests representation to byte array of type + requests data.
Closes #1086