Integrate with Tenderly and perform hash matching#783
Conversation
|
Note that |
|
This approach is great. Few comments: Running: I get an error: Running I get an error: It would be good to have some tests for this functionality. Also, is this a step that we're going to get signers to execute separately? How does it slot into the current flow? Or is that a future task? |
blmalone
left a comment
There was a problem hiding this comment.
Left a comment on the PR. I ran into some errors.
|
Fixed, please try: |
* refactor: addresses.toml not longer holding safe addresses. * fix: regression template tests fixed. * fix: nit * fix: add more docs to readme of base task. * fix: note to update base state diffs. * fix: fixed base sepolia validations.
* Minor fixes to sep/001 * mark ready
* update forge to use nightly version * generate op verify input as json files * fixes * fixes * add docs for it, use libstring and format json file * fixxx * update readme * Update src/improvements/justfile Co-authored-by: blaine <blainemalone01@gmail.com> * fix readme * fix readme * fixes * fixes * simplify, it's no more a breaking change * reduce diff * add natspec for outputOPVerifyInputToFile * use snake case for op verify inputs json folder, fix readme * fixx * improve log * add support for op-verify qr * Update src/improvements/tasks/MultisigTask.sol Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * do not use json * ... * ... * ... * ... * fix failing test * fixes * Update src/improvements/tasks/MultisigTask.sol Co-authored-by: smartcontracts <kelvinfichter@gmail.com> * Apply suggestions from code review Co-authored-by: smartcontracts <kelvinfichter@gmail.com> --------- Co-authored-by: blaine <blainemalone01@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
|
Scripts working again, although most tasks are broken themselves.
|
There was a problem hiding this comment.
I've left some comments on this. For some reason simulations aren't working for our U13 tasks anymore with these changes. I think it's because of the base contracts submodule change. Why is this included? It's not adding the TENDERLY_GAS env var to the Tenderly simulation link anymore.
I also ran just simulate-tenderly tasks/sep/001-opcm-upgrade-v200 child-safe-1 and I get the following error:
View the simulation in Tenderly dashboard:
https://dashboard.tenderly.co/oplabs/task-simulation/simulator/52633456-f754-41d8-8a16-f992f3c278a2
Error: Transaction failed in Tenderly
error: Recipe `simulate-tenderly` failed with exit code 1
When is this meant to get executed? I was expecting to see some CI job that runs this on every PR (or something like that - could be every merge to main).
Also, given how much churn has been included in this PR, can you add some tests? This could be a CI job that runs these checks.
|
I left some comments on slack, but the short of it is that the tasks in We can ignore exclude I've added a CI step that will pass once that task is fixed. I suggest that the scripts in this branch are used to facilitate that: |
…cript with optional parameters
|
I'll try again to get this merged when I'm back from leave. The conflicts shouldn't build up much, just on |
|
Going to close this PR. Superchain-ops has changed significantly since this PR was opened. If we want this feature, we will need to reprioritize it and then go back to the design stage. Let me know if I'm missing something here and you'd like to keep this PR open for another reason. |
Description
Please export the tenderly access token in the 1password EVM Safety vault as TENDERLY_ACCESS_TOKEN for the below to work.
just simulate-tenderly <path-to-task> <optional-safe-name>insrc/improvementssimulates a task both locally and on tenderly, both single and nested. Returns the usual output, the tenderly simulation link (already simulated, to save some time) and the hashes.just verify-non-terminal-taskssimulates locally and on tenderly all tasks that are not SIGNED or EXECUTED, and compares the domain and message hashes in VALIDATIONS.md against the ones in the simulations.