feat: add OPCMv2 tests for existing behaviors #18389
Open
+318
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18389 +/- ##
===========================================
+ Coverage 75.31% 80.24% +4.93%
===========================================
Files 187 132 -55
Lines 11199 7168 -4031
===========================================
- Hits 8434 5752 -2682
+ Misses 2621 1416 -1205
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0xiamflux
reviewed
Nov 26, 2025
|
|
||
| /// @notice Tests that the constructor succeeds on mainnet when the test env flag is set. | ||
| /// @param _devFeatureBitmap The dev feature bitmap to use. | ||
| function testFuzz_constructor_devBitmapOnMainnetButTestEnv_succeeds(bytes32 _devFeatureBitmap) public { |
Contributor
There was a problem hiding this comment.
nit: should we have this test for non-mainnet chains?
|
|
||
| /// @title OPContractsManagerContainer_IsDevFeatureEnabled_Test | ||
| /// @notice Tests the isDevFeatureEnabled() function. | ||
| contract OPContractsManagerContainer_IsDevFeatureEnabled_Test is OPContractsManagerContainer_TestInit { |
Contributor
There was a problem hiding this comment.
Maybe a sanity check, this should always hold:
assertFalse(container.isDevFeatureEnabled(bytes32(0)));
|
|
||
| assertFalse(container.isDevFeatureEnabled(_feature)); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe test for when multiple bits are set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for AddGameType and UpdatePrestate behaviors in OPCMv2. It also adds tests for OPContractsManagerContainer (the new version).