fix(op-node): fix safe head debounce #18385
Open
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearpebble
force-pushed
the
fix-fcu-debounce
branch
from
01b8469 to
e5b1a2d
Compare
Contributor
Author
|
@teddyknox @axelKingsley @pcw109550 could any of you take a quick look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I applied the debouce FCU PR #18234 to our fork, enabled debug logs on op-node and ran a devnet. I noticed that I was still getting FCU calls for every block in a batch, so no debouncing whatsoever. After looking at the code and the original PR #17901, I noticed there was likely a mistake with applying the changes and the line that should replace
e.needFCUCallwas added without replacing it.So the current version still performs an FCU on every safe head update instead of buffering them.