Skip to content

Conversation

@janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Nov 13, 2025

Description

A small shell typo in the script that publishes contract artifacts provided an ample opportunity to delete a couple of lines of code.

The reason why the script was failing in the first place was the fact that what was supposed to be a list of arguments to tar was passed as a single argument. The rest is just cleanup.

Fixes #18273

@janjakubnanista janjakubnanista requested review from a team as code owners November 13, 2025 19:28
@janjakubnanista janjakubnanista marked this pull request as draft November 13, 2025 19:28
@janjakubnanista janjakubnanista self-assigned this Nov 13, 2025
@janjakubnanista janjakubnanista added M-ci Meta: ci related work A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-op-deployer A-oncall labels Nov 13, 2025
@janjakubnanista janjakubnanista force-pushed the jan/publishing-failure branch 2 times, most recently from 354c825 to 47cc43b Compare November 15, 2025 02:43
@janjakubnanista janjakubnanista marked this pull request as ready for review November 15, 2025 02:44
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.10%. Comparing base (f3c8665) to head (4b775d5).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18275      +/-   ##
===========================================
+ Coverage    76.56%   82.10%   +5.53%     
===========================================
  Files          179      124      -55     
  Lines        10732     6699    -4033     
===========================================
- Hits          8217     5500    -2717     
+ Misses        2369     1199    -1170     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janjakubnanista janjakubnanista added this pull request to the merge queue Nov 18, 2025
Merged via the queue into develop with commit 3ab2b6e Nov 18, 2025
73 checks passed
@janjakubnanista janjakubnanista deleted the jan/publishing-failure branch November 18, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-oncall A-op-deployer A-pkg-contracts-bedrock Area: packages/contracts-bedrock M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oncall: Artifact publishing workflows fail

5 participants