Skip to content

Conversation

@DenseDenise
Copy link
Contributor

found this issue from #17496 (CI checks failed)

Fixes test failure by correcting the default value introduced in 3f2bf28 - req-resp sync should be opt-in, not opt-out.

cc @nonsense

@DenseDenise DenseDenise requested review from a team as code owners October 17, 2025 15:57
@nonsense
Copy link
Contributor

By default the op-node runs with this value equal to true. I don't see a reason why the default in tests should be false, the current version of develop is just fine in my opinion.

@DenseDenise
Copy link
Contributor Author

By default the op-node runs with this value equal to true. I don't see a reason why the default in tests should be false, the current version of develop is just fine in my opinion.

Or should we try other way to avoiding the CI fails?

@nonsense
Copy link
Contributor

@DenseDenise the test that failed is flaky (TestUnsafeChainStalling_DisabledReqRespSync), it needs the NoDiscovery modifier for the network, and it is not on develop unfortunately. I have fixed it as part of #17751 , but will probably merge sooner so that we have fewer flakes.

Thanks!

@nonsense nonsense closed this Oct 17, 2025
@nonsense
Copy link
Contributor

Added a PR for it at #17918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants