Skip to content

Conversation

@hexshire
Copy link
Contributor

@hexshire hexshire commented Sep 21, 2025

Description

This PR enhances the developer experience for op-up by adding ProxyAdmin management capabilities and improving the development workflow with better logging and predictable network access.

Key improvements:

  • Fixed L1 port: Set L1 geth to use port 8544 for predictable access (accessible via http://127.0.0.1:8544)
  • ProxyAdmin helper integration: Added WithL1ProxyAdminOwner and WithL2ProxyAdminOwner functions with deterministic key generation
  • Consolidated logging: All critical development information is now displayed on startup:
    • Test account address and private key
    • L1 ProxyAdmin owner address and private key
    • L2 ProxyAdmin owner address and private key
    • Ready-to-use URLs for both L1 and L2 nodes
  • Clean architecture: Refactored with getActor helper to centralize key generation logic

Tests

  • Manual testing verified:
    • Successful compilation and execution of op-up
    • L1 network accessible on http://127.0.0.1:8544
    • L2 network accessible on http://127.0.0.1:8545
    • All generated private keys work correctly for transactions
    • ProxyAdmin owners have proper funding and functionality

hexshire and others added 3 commits September 20, 2025 22:00
- Set L1 geth to use fixed port 8544 for predictable access
- Add ProxyAdmin owner addresses for L1 and L2 with generated keys
- Consolidate all account info logging in runOpUp for better organization
- Display both L1 (8544) and L2 (8545) node URLs
- Refactor getActor helper to centralize key generation logic
- Integration of WithL1ProxyAdminOwner and WithL2ProxyAdminOwner helpers

Developer experience improvements:
- Clear separation of L1/L2 ProxyAdmin ownership
- All critical addresses and private keys displayed on startup
- Deterministic key generation using consistent actor indexes
- Ready-to-use URLs for both L1 and L2 interactions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Both L1 and L2 nodes now display 127.0.0.1 URLs which work reliably
with cast and other tools, avoiding host validation issues.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Changed L2 proxy admin owner from key index 10002 to 10001 for consistency.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@hexshire hexshire requested review from a team as code owners September 21, 2025 03:21
@hexshire hexshire requested a review from mds1 September 21, 2025 03:21
…er functions

Added the helper functions that were missing for op-up to compile properly.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@hexshire hexshire marked this pull request as draft September 21, 2025 03:54
@hexshire hexshire marked this pull request as ready for review September 21, 2025 04:11
@hexshire hexshire changed the title fear: proxy admin and op up static ip devex(op-up): proxy admin override and l1 static ip Sep 22, 2025
@hexshire hexshire requested a review from tynes September 23, 2025 18:20
@tynes
Copy link
Contributor

tynes commented Sep 29, 2025

/ci authorize ce93b68

Name: "l1-geth",
HTTPHost: "127.0.0.1",
HTTPPort: 0,
HTTPPort: 8544,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to need to double check that this will not cause problems, I think that 0 was chosen so that it can run in parallel. cc @sebastianst @geoknee

@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Oct 13, 2025
@opgitgovernance
Copy link
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-stale Status: Will be closed unless there is activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants