-
Notifications
You must be signed in to change notification settings - Fork 3.8k
devex(op-up): proxy admin override and l1 static ip #17543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set L1 geth to use fixed port 8544 for predictable access - Add ProxyAdmin owner addresses for L1 and L2 with generated keys - Consolidate all account info logging in runOpUp for better organization - Display both L1 (8544) and L2 (8545) node URLs - Refactor getActor helper to centralize key generation logic - Integration of WithL1ProxyAdminOwner and WithL2ProxyAdminOwner helpers Developer experience improvements: - Clear separation of L1/L2 ProxyAdmin ownership - All critical addresses and private keys displayed on startup - Deterministic key generation using consistent actor indexes - Ready-to-use URLs for both L1 and L2 interactions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Both L1 and L2 nodes now display 127.0.0.1 URLs which work reliably with cast and other tools, avoiding host validation issues. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Changed L2 proxy admin owner from key index 10002 to 10001 for consistency. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…er functions Added the helper functions that were missing for op-up to compile properly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
/ci authorize ce93b68 |
tynes
reviewed
Sep 29, 2025
| Name: "l1-geth", | ||
| HTTPHost: "127.0.0.1", | ||
| HTTPPort: 0, | ||
| HTTPPort: 8544, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to need to double check that this will not cause problems, I think that 0 was chosen so that it can run in parallel. cc @sebastianst @geoknee
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the developer experience for op-up by adding ProxyAdmin management capabilities and improving the development workflow with better logging and predictable network access.
Key improvements:
Tests