Skip to content

Conversation

@nonsense
Copy link
Contributor

@nonsense nonsense commented Sep 19, 2025

Following up from recent improvements to our CI system, I am refactoring N packages back into 1, as tests now can run in parallel.


TODO:

  • Make sure that parallel runs are enabled on production CI.

@nonsense nonsense force-pushed the nonsense/ext-hfs-one-pkg branch from d315cf1 to 2a6a34f Compare September 19, 2025 14:48
@nonsense nonsense changed the title op-acceptance-tests: move sync-tester tests under one package op-acceptance-tests: move sync-tester hardforks tests under one package Sep 19, 2025
@nonsense nonsense force-pushed the nonsense/ext-hfs-one-pkg branch from 2a6a34f to 3088e0b Compare September 22, 2025 11:28
@nonsense nonsense requested a review from scharissis September 22, 2025 13:12
@nonsense
Copy link
Contributor Author

Hey @scharissis,

It appears that the tests within one package did not run in parallel:

Screenshot 2025-09-22 at 15 13 21

Let me know when we have the op-acceptor that supports this on production CI, and we can then merge this PR!

Thanks!

@scharissis
Copy link
Contributor

This branch and develop/production are currently using op-acceptor v3.2.1.
The parallelisation feature you're waiting for was introduced in v3.3.0.
I'm working on releasing that to develop for you to use.

@nonsense nonsense force-pushed the nonsense/ext-hfs-one-pkg branch from 3088e0b to 628045c Compare September 25, 2025 09:40
@nonsense nonsense requested a review from pcw109550 September 25, 2025 11:22
@nonsense nonsense marked this pull request as ready for review September 25, 2025 11:22
@nonsense nonsense requested a review from a team as a code owner September 25, 2025 11:22
@nonsense nonsense added this pull request to the merge queue Sep 25, 2025
Merged via the queue into develop with commit 0e4a942 Sep 25, 2025
64 checks passed
@nonsense nonsense deleted the nonsense/ext-hfs-one-pkg branch September 25, 2025 12:52
@scharissis
Copy link
Contributor

Nice. Glad we got this working :)

theochap pushed a commit that referenced this pull request Sep 26, 2025
…ge (#17535)

* op-acceptance-tests: move all ext hfs tests to a single pkg

* op-acceptance-tests/hfs-ext: change Serial to Parallel

* op-acceptance_tests: consolidate hardforks_ext and sync_tester_hfs_ext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants