sysgo: add Osaka activation test #17529

joshklop · 2025-09-19T06:06:30Z

No description provided.

op-acceptance-tests/tests/osaka/activation_test.go

geoknee · 2025-09-19T12:45:33Z

This is great, thanks @joshklop.

I ran the new test and watched the output. It's clear that op-geth does not support running an Osaka L1 yet.

I am working on an upstream merge here ethereum-optimism/op-geth#684, but that still won't allow us to run an Osaka L1. There is only unreleased upstream code which should let us do it.

geoknee · 2025-09-19T13:10:35Z

Another observation from the logs: the batcher in this test environment apparently uses calldata, not blobs.

That will give us a false sense of security since we expect blob submission in prod, and for this to break with Fusaka. Can we force the batcher to use blobs at least in the new test (and probably all the others too)?

codecov · 2025-09-24T19:43:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.31%. Comparing base (59b7d71) to head (9f3c38c).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #17529      +/-   ##
===========================================
- Coverage    74.62%   74.31%   -0.32%     
===========================================
  Files          172      172              
  Lines        10955    10955              
===========================================
- Hits          8175     8141      -34     
- Misses        2634     2670      +36     
+ Partials       146      144       -2

Flag	Coverage Δ
cannon-go-tests-64	`66.03% <ø> (-0.72%)`	⬇️
contracts-bedrock-tests	`80.72% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joshklop · 2025-10-06T05:07:29Z

Probably easiest to review commit-by-commit.

geoknee

LGTM

op-service/txplan/txplan.go

mise.toml

op-deployer/pkg/deployer/pipeline/seal_l1_dev_genesis.go

devnet-sdk/shell/env/devnet.go

op-acceptance-tests/tests/osaka/osaka_test.go

joshklop · 2025-10-06T13:45:02Z

As discussed out-of-band: pre-emptively resolving all comments to allow for merging. Will address comments in follow-ups.

#17529 (comment)

Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment)

Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment)

#17529 (comment)

Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment)

…17953) Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment)

…st (#17944) * split out helpers and initialization to a separate file * fix comment in mise.toml * rename osaka test * rename to fusaka * txplan: support non-cell proof blob txs * also verify the l1 blob base fee in the l1 block contract * optimization #17529 (comment) * op-acceptance-tests: harden the BPO blob base fee calculation test (#17953) Before, we merely waited for the blob base fee to rise above 1 before assuming that the blob parameters would have a visible impact on the fee. Due to rounding, it is possible that different parameters still result in the same base fee even above the minimum (either 1 or the reserve price set by EIP-7918). Calculating the precise intersections between different blob base fee formulae is complicated, so we opt for the simpler but maximally robust approach: calculate both the BPO1 base fee and the Osaka base fee, and only proceed when they differ. This resolves a nit on a previous PR that was merged due to time pressure: #17529 (comment) * add log

joshklop requested a review from geoknee September 19, 2025 06:06

geoknee reviewed Sep 19, 2025

View reviewed changes

op-acceptance-tests/tests/osaka/activation_test.go Outdated Show resolved Hide resolved

joshklop force-pushed the joshklop/osaka-override branch 4 times, most recently from 4d064ab to b42ddb1 Compare September 24, 2025 19:34

joshklop force-pushed the joshklop/osaka-override branch 5 times, most recently from ed50480 to 2587788 Compare September 25, 2025 18:24

joshklop marked this pull request as ready for review September 25, 2025 18:27

joshklop requested review from a team as code owners September 25, 2025 18:27

joshklop requested a review from janjakubnanista September 25, 2025 18:27

joshklop force-pushed the joshklop/osaka-override branch from 2587788 to 27d5316 Compare September 25, 2025 20:27

joshklop changed the base branch from develop to joshklop/l1-subprocess September 25, 2025 20:28

joshklop changed the title ~~sysgo: add ability to configure osaka offset~~ sysgo: add Osaka activation test Sep 25, 2025

joshklop force-pushed the joshklop/l1-subprocess branch from 2936d73 to 8417a3d Compare September 25, 2025 20:41

joshklop force-pushed the joshklop/osaka-override branch from 27d5316 to b6a99a3 Compare September 25, 2025 20:41

joshklop force-pushed the joshklop/l1-subprocess branch from 8417a3d to e961c6c Compare September 26, 2025 18:02

joshklop force-pushed the joshklop/osaka-override branch 2 times, most recently from ed4267c to 263e480 Compare September 26, 2025 18:46

joshklop force-pushed the joshklop/l1-subprocess branch from e961c6c to 09f1a75 Compare September 26, 2025 19:11

joshklop force-pushed the joshklop/osaka-override branch from 263e480 to f368540 Compare September 26, 2025 19:11

geoknee added the H-l1-fusaka-defense Soft fork for being compatible with an L1 which has activated Fusaka label Sep 27, 2025

joshklop force-pushed the joshklop/l1-subprocess branch from 09f1a75 to 94841db Compare September 29, 2025 21:43

sysext: infer L1 config when possible

9f3c38c

joshklop force-pushed the joshklop/osaka-override branch from 1107a12 to 9f3c38c Compare October 6, 2025 04:23

geoknee reviewed Oct 6, 2025

View reviewed changes

geoknee approved these changes Oct 6, 2025

View reviewed changes

geoknee reviewed Oct 6, 2025

View reviewed changes

op-acceptance-tests/tests/osaka/osaka_test.go Show resolved Hide resolved

geoknee reviewed Oct 6, 2025

View reviewed changes

op-acceptance-tests/tests/osaka/osaka_test.go Show resolved Hide resolved

joshklop added this pull request to the merge queue Oct 6, 2025

Merged via the queue into develop with commit 4e726c6 Oct 6, 2025
69 checks passed

joshklop deleted the joshklop/osaka-override branch October 6, 2025 14:06

geoknee mentioned this pull request Oct 7, 2025

acceptance tests: add tests for Fusaka activating on L1 #17499

Closed

joshklop added a commit that referenced this pull request Oct 20, 2025

optimization

97e3e1b

#17529 (comment)

joshklop mentioned this pull request Oct 20, 2025

op-acceptance-tests: various improvements to the Fusaka acceptance test #17944

Merged

joshklop added a commit that referenced this pull request Oct 21, 2025

optimization

c0829ab

#17529 (comment)

sysgo: add Osaka activation test #17529

sysgo: add Osaka activation test #17529

Uh oh!

Conversation

joshklop commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

geoknee commented Sep 19, 2025

Uh oh!

geoknee commented Sep 19, 2025

Uh oh!

codecov bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joshklop commented Oct 6, 2025

Uh oh!

geoknee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshklop commented Oct 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joshklop commented Sep 19, 2025 •

edited

Loading

codecov bot commented Sep 24, 2025 •

edited

Loading