opcm: Support cannon+kona games in updatePrestates #17512
Conversation
Inphi
force-pushed
the
aj/kona-updatePrestates
branch
2 times, most recently
from
274965f to
643a2af
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17512 +/- ##
===========================================
+ Coverage 74.62% 80.74% +6.12%
===========================================
Files 172 117 -55
Lines 10954 6175 -4779
===========================================
- Hits 8174 4986 -3188
+ Misses 2634 1189 -1445
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Inphi
force-pushed
the
aj/kona-updatePrestates
branch
from
5e4550e to
a2e436e
Compare
| } | ||
|
|
||
| /// @notice The input required to identify a chain for updating prestates | ||
| struct UpdatePrestateInput { |
There was a problem hiding this comment.
If the intention is to merge this with OpChainConfig, we should add a TODO so we don't forget to come back here.
There was a problem hiding this comment.
This is a replacement to OpChainConfig for prestate updates. OpChainConfig will still be used in other areas.
| systemConfig: chainDeployOutput1.systemConfigProxy, | ||
| /// @title OPContractsManager_UpdatePrestate_CannonKonaEnabled_Test | ||
| /// @notice Tests the `updatePrestate` function of the `OPContractsManager` contract with CANNON_KONA enabled. | ||
| contract OPContractsManager_UpdatePrestate_CannonKonaEnabled_Test is OPContractsManager_TestInit { |
There was a problem hiding this comment.
(nit) Feels like we could be more comprehensive by adding permutations on the test cases here. For example, showing we can deploy super-cannon-kona, or checking we revert if there is a super-cannon-kona game but no kona-prestate, etc. Maybe this is something we could come back to with a follow-up ticket TODO.
Description
Support cannon+kona games in updatePrestates. Uses a new struct to avoid updating ABI for
updateandmigrateyet. Ultimately should switch them all back to the same one but working more incrementally.