fix: Improve logging and fix function #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithdrawals - Switch from GetOutputRootFromTrustedL2Node to GetOutputRootFromCalculation - Enhance error messages with more context for block numbers - Add debug print for output root calculation - Update client references from l2OpNodeClient to l2OpGethClient
…-geth together with and merkle trie verification
- Introduce L2GethBackupURLs CLI flag to specify backup L2 execution layer client URLs - Implement GethBackupClientsDictionary to create and validate backup clients - Update CLIConfig, Monitor, and OpNodeHelper to support backup client functionality - Add node connections metric to track total node connection attempts - Enhance error handling and logging for backup client retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reason of the change:
It may happen that one of the backend L2 nodes does not have historical data that we need to retrieve. We can now pass also a sequence of L2 backup nodes that can be used in case the query to the main trusted node fails.
This change also drops the use of op-node in favor of op-geth.
To maintain compatibility with previous version, will ignore op-node if passed.
This pull request introduces several updates and improvements to the
op-monitorism/faultproof_withdrawalsmodule, focusing on deprecating certain flags, adding support for backup URLs, and enhancing monitoring and logging capabilities.Deprecation and Documentation Updates:
op-monitorism/faultproof_withdrawals/README.md: Deprecated the--l2.node.urlflag and updated documentation to reflect this change. [1] [2]New Features:
op-monitorism/faultproof_withdrawals/cli.go: Added support forl2.geth.backup.urlsflag to allow specifying backup L2 OP Stack execution layer client URLs. [1] [2] [3] [4]Code Enhancements:
op-monitorism/faultproof_withdrawals/monitor.go: Introduced handling for backup L2 clients and improved error logging when updating enriched withdrawal events. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Monitoring and Metrics:
op-monitorism/faultproof_withdrawals/state.go: Added a new counter for tracking the total number of node connections and updated the state and metrics logging to include this new counter. [1] [2] [3] [4] [5] [6] [7] [8] [9]Tests
Additional context
Metadata