-
Notifications
You must be signed in to change notification settings - Fork 31
test: replace log.New() with testlog.Logger in psp_executor tests #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the logger initialization in the test functions within the file Changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
This PR replaces the standard logger (
log.New()
) withtestlog.Logger
in theop-defender/psp_executor/api_test.go
test file. This change improves test output handling by:The change addresses multiple TODO comments in the codebase regarding logger replacement in test files.
Tests
The changes were made directly to test files, specifically:
TestHTTPServerHasCorrectRoute
TestDefenderInitialization
TestHandlePostMockFetch
TestGetNonceSafe
TestCheckPauseStatus
All existing tests continue to pass with the new logger implementation.
Additional context
This change is part of a larger effort to standardize test logging across the codebase using
testlog
. Thetestlog
package is specifically designed for test environments and provides better control over log output during test execution.Metadata