Add SHARP token details to the Ethereum tokens list #965
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds token metadata for the SHARP token to the Ethereum tokens list, including contract address, symbol, decimals, and community links.
- Adds a new JSON configuration file for the SHARP token on Ethereum
- Includes standard token metadata (symbol, name, address, decimals)
- Provides comprehensive community links and branding information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "github": "https://github.com/SharpEconomy", | ||
| "telegram": "https://t.me/SharpEconomy", | ||
| "discord": "https://discord.gg/sharpeconomy", | ||
| "polygonscan": "https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244", |
There was a problem hiding this comment.
The polygonscan URL references a Polygon network block explorer, but this token file is in the Ethereum (eth) directory. This should either be an Etherscan URL for the Ethereum network or this entry should be removed if the token is only on Ethereum.
| "polygonscan": "https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244", |
Copilot uses AI. Check for mistakes.
| { | ||
| "symbol": "SHARP", | ||
| "name": "SHARP", | ||
| "address": "0xB36B62929762ACF8A9Cc27ECebF6D353eBB48244", |
There was a problem hiding this comment.
The address casing is inconsistent between the token address field (mixed case) and the polygonscan URL (lowercase). For consistency, both should use the same casing format.
Copilot uses AI. Check for mistakes.
| "github": "https://github.com/SharpEconomy", | ||
| "telegram": "https://t.me/SharpEconomy", | ||
| "discord": "https://discord.gg/sharpeconomy", | ||
| "polygonscan": "https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244", |
There was a problem hiding this comment.
The address casing is inconsistent between the token address field (mixed case) and the polygonscan URL (lowercase). For consistency, both should use the same casing format.
| "polygonscan": "https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244", | |
| "polygonscan": "https://polygonscan.com/token/0xB36B62929762ACF8A9Cc27ECebF6D353eBB48244", |
Copilot uses AI. Check for mistakes.
Changed the Telegram URL in the SharpEconomy token metadata to use the correct handle (sharp_economy) for improved accuracy.
The token is only compatible with Polygon PoS (chainId 137). No Ethereum-mainnet contract, so no Etherscan URL applies. Polygonscan reference: https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244. File placed per repo README: single JSON named by the contract address in ERC-55 checksum under tokens/ with required fields (symbol, name, address, decimals). Optional fields follow README (website, GitHub, community). For context, prior PR ethereum-lists#965 used tokens/eth/…, which targets Ethereum-mainnet and prompted the Etherscan request. This PR corrects the path and chain clarification
The token is only compatible with Polygon PoS (chainId 137). No Ethereum-mainnet contract, so no Etherscan URL applies. Polygonscan reference: https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244. File placed per repo README: single JSON named by the contract address in ERC-55 checksum under tokens/ with required fields (symbol, name, address, decimals). Optional fields follow README (website, GitHub, community). For context, prior PR ethereum-lists#965 used tokens/eth/…, which targets Ethereum-mainnet and prompted the Etherscan request. This PR corrects the path and chain clarification
Create 0xB36B62929762ACF8A9Cc27ECebF6D353eBB48244.json
|
The token is only compatible with Polygon PoS (chainId 137). No Ethereum-mainnet contract, so no Etherscan URL applies. Polygonscan reference: https://polygonscan.com/token/0xb36b62929762acf8a9cc27ecebf6d353ebb48244. File placed per repo README: single JSON named by the contract address in ERC-55 checksum under tokens/ with required fields (symbol, name, address, decimals). Optional fields follow README (website, GitHub, community). For context, prior PR #965 used tokens/eth/…, which targets Ethereum-mainnet and prompted the Etherscan request. This PR corrects the path and chain clarification |
No description provided.