Skip to content

Conversation

JordyDutch
Copy link

@JordyDutch JordyDutch commented Sep 17, 2025

Hello Team!

I've updated the data for both LUKSO Mainnet and Testnet.

Changes

  • Updated the info for the LUKSO Mainnet and Testnet networks.
  • Differentiated the icon for Testnet from Mainnet and updated the icons to the current ones.
  • Updated RPC's
  • We had a reusedChainId flag since we are using the ID that Kovan was using previously, but since Kovan got deprecated a long time ago I think it's time to remove this so that we can show up in the UI 🙏🏼

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

"chainId": 42,
"networkId": 42,
"features": [{ "name": "EIP155" }, { "name": "EIP1559" }],
"redFlags": ["reusedChainId"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 5977901

@JordyDutch JordyDutch force-pushed the Update-LUKSO-Mainnet-&-Testnet branch 2 times, most recently from f65036c to bffef1a Compare September 30, 2025 07:15
@JordyDutch JordyDutch force-pushed the Update-LUKSO-Mainnet-&-Testnet branch from bffef1a to 0f54cf1 Compare September 30, 2025 07:17
@@ -1,8 +1,8 @@
[
{
"url": "ipfs://Qmeg9sFF5tAGi6MCx7YjtVHW6a23zqvHRK1xwzSdp9iE7z",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the old instance of Qmeg9sFF5tAGi6MCx7YjtVHW6a23zqvHRK1xwzSdp9iE7z in iconsDownload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants