Update polkadot testnet & mainnet Asset Hub chains#7151
Update polkadot testnet & mainnet Asset Hub chains#7151pgherveou wants to merge 4 commits intoethereum-lists:masterfrom
Conversation
pgherveou
commented
Apr 4, 2025
pgherveou
commented
- Update Polkadot & Kusama Asset Hub chains
- Update Westend (testnet) block explorer URL
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
Metamask issues a warning because the token and network name wasn't matching the upstream chain definition. Need to change network name to just Westend once ethereum-lists/chains#7151 is merged.
|
@FrederikBolding This is ready from our point of view. Humbly requesting a review. |
We should just refer to everything by its network name (Polkadot, Kusama, Westend). AssetHub is an implementation detail. This will also change the network name in wallet connect to just "Westend". It will through a warning until ethereum-lists/chains#7151 is merged, though.
| { | ||
| "name": "Westend Asset Hub", | ||
| "chain": "WST", | ||
| "name": "Westend", |
There was a problem hiding this comment.
Why is the Asset Hub suffix being stripped? Aren't all of the chains modified in this PR asset hubs?
There was a problem hiding this comment.
We made the decision that mentioning individual chains to the user is confusing. AssetHub is the designated place to interact with the whole of Polkadot (or its testnets). So when saying Polkadot you implicitly mean Polkadot AssetHub. We are trying to clean up the amount of words people need to learn. Polkadot itself doesn't have any user facing functionality. It will all be on AssetHub eventually.
There was a problem hiding this comment.
@FrederikBolding I confirm that this is the agreed on terminology.
|
@FrederikBolding Can we go ahead and merge this? Or are there other concerns from your side? |
|
This PR has no activity in a while - it will be closed soon. |
|
@FrederikBolding is there anything missing to merge this PR? |
|
@FrederikBolding is this PR good to be merged? |
|
closing this @albertov19 will open a new one |
4 participants
