Update BLS signature/verification to follow Commit-Boost signer module#67
Open
JasonVranek wants to merge 24 commits intomainfrom
Open
Update BLS signature/verification to follow Commit-Boost signer module#67JasonVranek wants to merge 24 commits intomainfrom
JasonVranek wants to merge 24 commits intomainfrom
Conversation
- Changes to IRegistry - Fixes to broken Registry.t.sol
computeSigningRoot() was not using BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_NUL_ because it was converting the signingRoot to a G2 point by hand instead of using BLS.hashToG2(). The testValidG2Point case now produces a G2Point identical to what's generated in rust.
* Use hashToG2 when computing signingRoot computeSigningRoot() was not using BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_NUL_ because it was converting the signingRoot to a G2 point by hand instead of using BLS.hashToG2(). The testValidG2Point case now produces a G2Point identical to what's generated in rust. * Modify hashToG2 to use BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_POP_
Without including these fields it was unclear how people would verify offchain SignedDelegation messages
AnshuJalan
reviewed
Oct 3, 2025
config/registry.json
Outdated
| "optInDelay": 7200 | ||
| "optInDelay": 7200, | ||
| "signingDomain": "0x00000000000000000000000000000000000000000000000000000000436f6d6d", | ||
| "chainId": "0x0000000000000000000000000000000000000000000000000000000000000001" |
Contributor
There was a problem hiding this comment.
Shouldn't this be little-endian? I see chainId is not converted to little-endian later. It is used as-is from the config
Contributor
Author
There was a problem hiding this comment.
This file is just a template for the scripts but great catch, fixing now!
AnshuJalan
approved these changes
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We adjust the signature scheme to follow https://github.com/Commit-Boost/commit-boost-client/blob/sigp-audit-fixes/docs/docs/res/img/prop_commit_tree.png