Adding descriptions to Alps tests (first round) #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds descriptive text (descr attribute) to various Alps test classes to improve test documentation and clarity. The changes focus on providing clear, concise descriptions for what each test validates or benchmarks.
- Added
descrattributes to test classes across multiple directories (system checks, microbenchmarks, container engine tests, and application tests) - Converted existing docstring to
descrattribute for the SlurmGPUGresTest class - Enhanced test documentation for container engine tests, GPU/CPU burn tests, communication benchmarks, and PyTorch tests
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| checks/system/slurm/gres_gpu.py | Converted docstring to descr attribute for Slurm GPU GRES test |
| checks/system/ce/ce_import_run_image.py | Added descriptions for container engine import and run tests |
| checks/microbenchmarks/cpu_gpu/node_burn/node-burn-ce.py | Added descriptions for GPU and CPU node burn GEMM and Stream tests |
| checks/containers/container_engine/xccl_tests.py | Added descriptions for NCCL and RCCL communication tests |
| checks/containers/container_engine/ssh.py | Added description for SSH availability check |
| checks/containers/container_engine/omb.py | Added descriptions for OSU Micro-benchmarks tests |
| checks/containers/container_engine/cuda_mps.py | Added description for CUDA MPS check |
| checks/containers/container_engine/check_cuda_nbody.py | Added description for CUDA N-Body test |
| checks/apps/pytorch/pytorch_megatronlm.py | Added description for Megatron LM tests |
| checks/apps/pytorch/pytorch_allreduce.py | Added descriptions for PyTorch all-reduce benchmarks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jgphpc
reviewed
Oct 2, 2025
jgphpc
reviewed
Oct 2, 2025
| 'aws_ofi_nccl.enabled': 'true', | ||
| 'aws_ofi_nccl.variant': 'cuda12', | ||
| }, | ||
| } |
jgphpc
reviewed
Oct 2, 2025
|
|
||
| @run_after('setup') | ||
| def set_executable_opts(self): | ||
| self.prerun_cmds = ['wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/PyTorch/all_reduce_bench.py'] # noqa: E501 |
There was a problem hiding this comment.
Suggested change
| self.prerun_cmds = ['wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/PyTorch/all_reduce_bench.py'] # noqa: E501 |
jgphpc
reviewed
Oct 2, 2025
| @performance_function('GB/s') | ||
| def bandwidth(self): | ||
| return sn.extractsingle(r'\|\s*16GiB\s*\|\s*(?P<busbw>\S+)GBps\s*\|', | ||
| self.stdout, tag='busbw', conv=float |
There was a problem hiding this comment.
Suggested change
| self.stdout, tag='busbw', conv=float) |
jgphpc
reviewed
Oct 2, 2025
jgphpc
reviewed
Oct 2, 2025
jgphpc
reviewed
Oct 2, 2025
jgphpc
reviewed
Oct 2, 2025
| @run_after('setup') | ||
| def set_nccl_min_nchannels(self): | ||
| gpu_devices = self.current_partition.select_devices('gpu')[0] | ||
|
|
jgphpc
reviewed
Oct 2, 2025
jgphpc
reviewed
Oct 2, 2025
jgphpc
reviewed
Oct 2, 2025
| @sanity_function | ||
| def assert_sanity(self): | ||
| return sn.assert_found(r'^\d+ /opt/oci-hooks/ssh/dropbear/bin/dropbear.*-p 15263.*$', self.stdout) | ||
|
|
jgphpc
approved these changes
Oct 2, 2025
gppezzi
changed the title
teojgo
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.