Issue #82: Prevent is react field null error#226
Open
sebastianbarrozo wants to merge 2 commits intomainfrom
Open
Issue #82: Prevent is react field null error#226sebastianbarrozo wants to merge 2 commits intomainfrom
sebastianbarrozo wants to merge 2 commits intomainfrom
Conversation
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
etendobot
approved these changes
Feb 12, 2026
etendobot
approved these changes
Feb 12, 2026
There was a problem hiding this comment.
Pull request overview
Fixes Issue #82 by making the Projection bean resilient to null values coming from the model’s isReact() flag, preventing a null-unboxing error during entity/code generation.
Changes:
- Add a null-safe check when reading
projection.getModule().isReact()to populate the primitivereactfield.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| this.projection = projection; | ||
| this.grpc = projection.isGrpc(); | ||
| this.react = projection.getModule().isReact(); | ||
| this.react = projection.getModule().isReact() != null && projection.getModule().isReact(); |
There was a problem hiding this comment.
projection.getModule().isReact() is evaluated twice here. Consider reading it into a local variable or using Boolean.TRUE.equals(projection.getModule().isReact()) to both handle null safely and avoid duplicate calls, improving readability/maintainability.
Suggested change
| this.react = projection.getModule().isReact() != null && projection.getModule().isReact(); | |
| this.react = Boolean.TRUE.equals(projection.getModule().isReact()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ETP-3361