fix: use require instead of t.Fatal(err) in tests/common package

[mmorel-35]

Description

This uses testify instead of testing for t.Fatal calls

Related to #18972

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mmorel-35]

/assign @ahrtr

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (3de0018) to head (7e3dcfa).
Report is 4 commits behind head on main.

❗ Current head 7e3dcfa differs from pull request most recent head 36a5e40

Please upload reports for the commit 36a5e40 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18823      +/-   ##
==========================================
- Coverage   68.76%   68.69%   -0.07%     
==========================================
  Files         420      420              
  Lines       35523    35523              
==========================================
- Hits        24426    24402      -24     
- Misses       9665     9689      +24     
  Partials     1432     1432              

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de0018...36a5e40. Read the comment docs.

[ivanvc]

/ok-to-test

[mmorel-35]

/test pull-etcd-integration-1-cpu-amd64

[ahrtr]

LGTM

Thanks

[ivanvc]

LGTM. Thanks, @mmorel-35.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment