-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[augerctl] Support watch for get #93
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a2a05ca
to
48e7cce
Compare
48e7cce
to
855e529
Compare
/cc @jmhbnz |
Hey @wzshiming - I'll review this one next, can you please rebase to fix conflicts, thanks! 🙏🏻 |
855e529
to
bfce023
Compare
Done, thank you for reviewing it 😄 |
clientv3 "go.etcd.io/etcd/client/v3" | ||
) | ||
|
||
func (c *client) Watch(ctx context.Context, prefix string, opOpts ...OpOption) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wzshiming - General question, have you put any thought into potential approaches for writing tests for augerctl
? To add new features it gets easier over time if we have tests to verify existing features don't break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, my original plan was to add the e2e test after the subcommand get.
Signed-off-by: Shiming Zhang <[email protected]>
bfce023
to
1a58621
Compare
part of #3
Test
Preparation cluster
Create a cluster and expose etcd port, to facilitate the creation of a cluster using kwokctl, this can be any other k8s cluster
# brew install kwok kwokctl create cluster --etcd-port 2379
Watch leases changes