Create foundation for a controller status history view #1402
Conversation
| {intl.formatMessage({ id: headerMessageId })} | ||
| </Typography> | ||
|
|
||
| {Hydrating ?? children} |
There was a problem hiding this comment.
Whenever there is a capitalized props like Hydrating I assume it takes in a functional component and used like
<Hydrating {...whatever props you might need}/>
In this scenario it looks like all 3 uses of this are passing in a skeleton with different sizes. I think we should just pass in the sizing they want and then this component itself can handle checking hydration.
There was a problem hiding this comment.
Mentioned in dailies... but putting here so there is an actual record of this.
I think we should move this out of deps as that is mainly for dependencies that are getting pulled in from external places.
| accessToken: string, | ||
| catalogName: string | ||
| ): Promise<EntityStatusResponse[]> => | ||
| client(`${entityStatusBaseEndpoint}?name=${catalogName}`, {}, accessToken); |
There was a problem hiding this comment.
I think probably best to do it here - but we need to make sure catalogName is safe / escaped. Normally we have used escapeReservedCharacters but that is really for PostgREST so not 100% sure what we wanna do here.
Issues
The issues directly below are advanced by this PR:
#1377
Changes
1377
The following features are included in this PR:
Create an environment variable for the base
/statusendpoint URL.Add a declaration file for control-plane types relevant to the
/statusendpoint.Add a Status section to the Logs tab of the Details page which serves as the foundation for comprehensive entity status view.
Update the shared
CardWrappercomponent to support a headerless display.Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
Initialization
Hydration failed | Error returned by
/statusendpointPost-Initialization
Dashboard view
Code view
No controller status history returned by
/statusendpointUpdating the view via the Refresh CTA | Table View