Remove full uppercase from blog post and success story titles #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 603c8a1): https://estuary-marketing--pr668-brenosalv-feature-65-oxou5k3n.web.app (expires Fri, 07 Mar 2025 05:07:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e |
travjenkins
reviewed
Feb 5, 2025
| @@ -54,11 +54,12 @@ | |||
| h1 { | |||
| margin-top: 36px; | |||
| color: var(--grey); | |||
| text-transform: uppercase; | |||
| text-transform: none; | |||
There was a problem hiding this comment.
Do we truly need this? Is another style trying to uppercase this?
There was a problem hiding this comment.
Yes, as most of the h1 are uppercased, I added uppercase style globally to all the h1 and just removed this on blog post and success story cases.
travjenkins
deleted the
Brenosalv/feature/650-dont-full-uppercase-blog-post-and-success-story-titles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests / Screenshots