Refactor/remove opengraph #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
commented
Sep 27, 2022
| alter view live_specs_ext owner to authenticated; | ||
|
|
||
| -- Extended view of user draft specifications. | ||
| create view draft_specs_ext as |
There was a problem hiding this comment.
@jgraettinger in response to your question about why I'm recreating draft_specs_ext here, it's because we have to recreate live_specs_ext to remove the connector_open_graph field, and draft_specs_ext depends on it. Nothing is changing in draft_specs_ext itself.
|
@jgraettinger you mentioned wanting me to wrap (something) in |
Can't seem to drop `generate_opengraph_value()`...
jshearer
force-pushed
the
refactor/remove_opengraph
branch
from
03e1fe6 to
d0bd181
Compare
|
Alrighty, finally managed to test this successfully locally! Everything seems to work, so I think we're good to merge. Next steps:
|
oliviamiannone
added
the
docs complete / NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Nuking left-over opengraph stuff after implementing estuary/animated-carnival#58. Original PR was at estuary/animated-carnival#67, which got rolled into the Flow repo.
Deleted
scripts/seed_connectors.sqlas per @jgraettinger: estuary/animated-carnival#67 (comment)Blocked on testing locally, which seems to be temporarily broken in current
masterThis change is