source-facebook-marketing: use existing session to fetch thumbnail urls #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fetch_thumbnail_data_url` function was not re-using the existing `requests.Session` & was instead making one-off `requests.get` calls. This caused a DNS query for each `fetch_thumbnail_data_url` invocation, and overall causes a TON of excessive, identical DNS queries. By using the existing `requests.Session` instance to make fetch thumbnail URLs, DNS queries are much less frequent since connections can be reused.
Alex-Bair
deleted the
bair/source-facebook-marketing-reduce-dns-query-frequency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
fetch_thumbnail_data_urlfunction was not re-using the existingrequests.Session& was instead making one-offrequests.getcalls. This caused a DNS query for eachfetch_thumbnail_data_urlinvocation, and overall causes a TON of excessive, identical DNS queries.By using the existing
requests.Sessioninstance to fetch thumbnail URLs, DNS queries are much less frequent since connections are reused.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed that the frequency of DNS queries after this change are significantly lower.
This change is