-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
materialize-iceberg: column type migrations #2540
Open
williamhbaker
wants to merge
4
commits into
main
Choose a base branch
from
wb/iceberg-migrations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
97ba330
materializer: support for column migrations
williamhbaker 55f9144
materialize-iceberg: make integration tests work with concurrent CI runs
williamhbaker c1ea82c
materialize-iceberg: get rid of `getHighestFieldID`
williamhbaker ded4a69
materialize-iceberg: column type migrations
williamhbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
--- Original Schema --- | ||
table { | ||
1: firstKey: required long | ||
2: secondKey: required string | ||
3: val1: required string | ||
4: val2: optional boolean | ||
5: dateToStr: required date | ||
6: intToDecimal: optional long | ||
7: decimalToFloat: required decimal(38, 0) | ||
8: timestampToStr: required timestamptz | ||
10: dateToStr_flow_tmp: required double | ||
} | ||
|
||
--- Next Schema --- | ||
table { | ||
1: firstKey: required long | ||
2: secondKey: required string | ||
3: val1: required string | ||
4: val2: optional boolean | ||
5: dateToStr: optional date | ||
6: intToDecimal: optional long | ||
7: decimalToFloat: required decimal(38, 0) | ||
8: timestampToStr: required timestamptz | ||
13: new: optional string | ||
14: dateToStr_flow_tmp: optional string | ||
15: intToDecimal_flow_tmp: optional decimal(38, 0) | ||
16: decimalToFloat_flow_tmp: required double | ||
17: timestampToStr_flow_tmp: optional string | ||
} | ||
|
||
--- After Migrate Schema --- | ||
table { | ||
1: firstKey: required long | ||
2: secondKey: required string | ||
3: val1: required string | ||
4: val2: optional boolean | ||
13: new: optional string | ||
14: dateToStr: optional string | ||
15: intToDecimal: optional decimal(38, 0) | ||
16: decimalToFloat: required double | ||
17: timestampToStr: optional string | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.