Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize-iceberg: use a different mechanism for computing the highest field ID from a schema #2535

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Mar 14, 2025

Description:

We are stuck on an old version of iceberg-go for now that does not account for certain logical types when computing the highest field ID for an existing schema. This creates a simple stand-in for doing that correctly with the column types we use.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

…est field ID from a schema

We are stuck on an old version of iceberg-go for now that does not account for
certain logical types when computing the highest field ID for an existing
schema. This creates a simple stand-in for doing that correctly with the column
types we use.
@williamhbaker williamhbaker requested a review from Alex-Bair March 14, 2025 15:59
Copy link
Member

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit 62a91f9 into main Mar 14, 2025
56 of 59 checks passed
@williamhbaker williamhbaker deleted the wb/iceberg-field-ids branch March 14, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants