Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hubspot-native: Expand HubSpot Engagement associations #2505

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

JustinASmith
Copy link
Contributor

@JustinASmith JustinASmith commented Mar 9, 2025

Description:

Expand HubSpot Engagement associations to support multiple object types. Update the Engagement model and schema to include associations for contacts, companies, tickets, content, quotes, orders, emails, meetings, notes, tasks, and carts.

HubSpot's V1 API for Engagements returns the following associations:

"engagement": {
    ...
    "associations": {
        "contactIds": [],
        "companyIds": [],
        "dealIds": [],
        "ownerIds": [],
        "workflowIds": [],
        "ticketIds": [],
        "contentIds": [],
        "quoteIds": [],
        "marketingEventIds": [],
        "partnerClientIds": [],
        "orderIds": [],
        "cartIds": []
    },
    ...
}

However, when testing each using HubSpot's batch read associations endpoint, I was only able to get valid API responses for those in bold.

  • contacts
  • companies
  • deals
  • tickets
  • quotes
  • orders
  • emails
  • meetings
  • notes
  • tasks
  • content
  • orders
  • carts
  • marketing events - only marketing_event worked - not marketing_events
  • partner clients
  • owners - is a top-level property, ownerId
  • workflows

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

…ort multiple object types

Update the Engagement model and schema to include associations for contacts, companies, tickets, content, quotes, orders, emails, meetings, notes, tasks, carts, partner_clients, and marketing_event.
@JustinASmith JustinASmith marked this pull request as ready for review March 9, 2025 19:04
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustinASmith JustinASmith merged commit fa709b8 into main Mar 11, 2025
82 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants