source-mongodb: additional debug logs when discarding documents #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
changed the title
Debug logging for when documents are discarded because they are not for a tracked operation type, or because the full document is empty. Both of these event types should be fairly low-volume. Also adds a sanity check when combining fragments from a split event to make sure that a source MongoDB collection is determined, which could otherwise cause a false negative when checking if that collection is among the tracked collections. I have no present reason to think this will ever happen, but it seems worthwhile to verify.
williamhbaker
force-pushed
the
wb/mongodb-logs
branch
from
51d0c91 to
8e5b614
Compare
mdibaiee
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Debug logging for when documents are discarded because they are not for a tracked operation type, or because the full document is empty. Both of these event types should be fairly low-volume.
Also adds a sanity check when combining fragments from a split event to make sure that a source MongoDB collection is determined, which could otherwise cause a false negative when checking if that collection is among the tracked collections. I have no present reason to think this will ever happen, but it seems worthwhile to verify.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is