Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialie-databricks: let databricks driver logs through on debug #2498

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Mar 7, 2025

Description:

  • I realised we were suppressing logs from databricks sql driver, I'm changing this to only suppress those logs in INFO level. Initially I had seen it log a lot in INFO mode and be confusing for customers, but on debug this could have helped us uncover the databricks bug earlier

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee requested a review from williamhbaker March 7, 2025 13:33
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdibaiee mdibaiee merged commit a37ee4f into main Mar 7, 2025
56 of 58 checks passed
@mdibaiee mdibaiee deleted the mahdi/db-logs branch March 7, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants