Skip to content

Commit

Permalink
source-oracle: floating points can be keys
Browse files Browse the repository at this point in the history
  • Loading branch information
mdibaiee committed Jan 30, 2025
1 parent 0bb08d7 commit 3093e4e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions source-oracle/discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,6 @@ func getColumns(ctx context.Context, conn *sql.DB, tables []*sqlcapture.Discover

if isPrimaryKey {
var streamID = sqlcapture.JoinStreamID(sc.TableSchema, sc.TableName)
if format == "number" {
return nil, nil, fmt.Errorf("floating point numbers cannot be primary keys: %s.%s", streamID, sc.Name)
}

pks[streamID] = append(pks[streamID], sc.Name)
}
Expand Down

0 comments on commit 3093e4e

Please sign in to comment.